If crypto_rng_get_bytes returns an error code, returning it is a good idea, but if it simply returns zero, the test shouldn't abort successfully. Signed-off-by: George Spelvin <linux@xxxxxxxxxxx> --- crypto/testmgr.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/crypto/testmgr.c b/crypto/testmgr.c index 0e179c72..9faf265f 100644 --- a/crypto/testmgr.c +++ b/crypto/testmgr.c @@ -1476,6 +1476,8 @@ static int test_cprng(struct crypto_rng *tfm, "the correct amount of random data for " "%s (requested %d, got %d)\n", algo, template[i].rlen, err); + if (err >= 0) + err = -EINVAL; break; } } -- 2.1.3 -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
