Re: [PATCH] crypto: drbg: use memzero_explicit() for clearing sensitive data

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Nov 24, 2014 at 10:21:16AM -0500, Nickolaus Woodruff wrote:
> diff --git a/include/crypto/drbg.h b/include/crypto/drbg.h
> index 5186f75..13471a2 100644
> --- a/include/crypto/drbg.h
> +++ b/include/crypto/drbg.h
> @@ -45,6 +45,7 @@
>  #include <crypto/hash.h>
>  #include <linux/module.h>
>  #include <linux/crypto.h>
> +#include <linux/string.h>

Why are you adding the inclusion to drbg.h? This file is for
users of drbg.  Please add it to drbg.c instead.

Thanks,
-- 
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux