Hi Herbert, thanks for the review. > -----Original Message----- > From: devicetree-owner@xxxxxxxxxxxxxxx [mailto:devicetree- > owner@xxxxxxxxxxxxxxx] On Behalf Of Herbert Xu > Sent: 20 November 2014 14:22 > To: James Hartley > Cc: davem@xxxxxxxxxxxxx; grant.likely@xxxxxxxxxx; robh+dt@xxxxxxxxxx; > gregkh@xxxxxxxxxxxxxxxxxxx; linux-crypto@xxxxxxxxxxxxxxx; > devicetree@xxxxxxxxxxxxxxx; pawel.moll@xxxxxxx; > mark.rutland@xxxxxxx; ijc+devicetree@xxxxxxxxxxxxxx; > galak@xxxxxxxxxxxxxx; Ezequiel Garcia; abrestic@xxxxxxxxxxxx > Subject: Re: [PATCH V2 1/2] crypto: Add Imagination Technologies hw hash > accelerator > > On Tue, Nov 18, 2014 at 08:48:46PM +0000, James Hartley wrote: > > > > +struct img_hash_request_ctx { > > + struct img_hash_dev *hdev; > > + u8 digest[SHA256_DIGEST_SIZE] __aligned(sizeof(u32)); > > + unsigned long flags; > > + size_t digsize; > > + > > + dma_addr_t dma_addr; > > + size_t dma_ct; > > + > > + /* sg root */ > > + struct scatterlist *sgfirst; > > + /* walk state */ > > + struct scatterlist *sg; > > + size_t nents; > > + size_t offset; > > + unsigned int total; > > + size_t sent; > > + > > + unsigned long op; > > + > > + size_t bufcnt; > > + u8 buffer[0] __aligned(sizeof(u32)); }; > > Unfortunately this is not consistent with our API since you're not storing the > non-final hash state in the request context. > > It appears that you're finalising every request. That means you can only > implement finup and digest. With finup you'll also need to be able to import > a non-final hash state. If the hardware cannot do that then you can only > implement digest. > > Everything else would have to be done by a fallback driver. > > So the question is can you obtain the non-final hash state from the hardware > and then reinsert it for the next operation? I've looked into this and unfortunately the hardware cannot do that. I'll spend some time looking into what this means (I'm not the author of the driver, so will need to become a bit more familiar with it). > > Cheers, > -- > Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: > http://gondor.apana.org.au/~herbert/ > PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in the > body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at > http://vger.kernel.org/majordomo-info.html Thanks, James. -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
