On 17 November 2014 16:09, Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote: > On Fri, Nov 14, 2014 at 01:34:59PM -0800, Kees Cook wrote: >> This prefixes all crypto module loading with "crypto-" so we never run >> the risk of exposing module auto-loading to userspace via a crypto API, >> as demonstrated by Mathias Krause: >> >> https://lkml.org/lkml/2013/3/4/70 >> >> Signed-off-by: Kees Cook <keescook@xxxxxxxxxxxx> > > Sorry but this doesn't build for me: > > CC [M] drivers/crypto/qat/qat_common/adf_ctl_drv.o > drivers/crypto/qat/qat_common/adf_ctl_drv.c:490:21: error: expected declaration specifiers or ‘...’ before string constant > make[3]: *** [drivers/crypto/qat/qat_common/adf_ctl_drv.o] Error 1 > make[2]: *** [drivers/crypto/qat/qat_common] Error 2 > make[1]: *** [drivers/crypto/qat] Error 2 > make[1]: *** Waiting for unfinished jobs.... Looks like drivers/crypto/qat/qat_common/adf_ctl_drv.c is missing '#include <linux/crypto.h>'. Mathias -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html