Hi Kim, Herbert, On 11/05/2014 06:43 PM, Kim Phillips wrote: > On Wed, 5 Nov 2014 11:21:24 +0200 > Cristian Stoica <cristian.stoica@xxxxxxxxxxxxx> wrote: > >> The error code returned by hardware is four bits wide with an expected >> zero MSB. A hardware error condition where the error code can get between >> 0x8 and 0xf will trigger an out of bound array access on the error >> message table. >> This patch fixes the invalid array access following such an error and >> reports the condition. >> >> Signed-off-by: Cristian Stoica <cristian.stoica@xxxxxxxxxxxxx> >> --- > no v2 change info? All I noticed is the additional string for > "queue manager interface", which, without its implementation fn, Yes. Thanks for review. That and the updated comment. > intoduces an inconsistency wrt NULL checking, so this comment: No. There is no inconsistency in the handling. Please be more specific. > > http://www.mail-archive.com/linux-crypto@xxxxxxxxxxxxxxx/msg12105.html > > still applies. Which comment? You refer to a whole email. My rebutal still applies though and I think your version is inferior wrt handling the issue. Feel free to send a competing patch for review though. Herbert, consider that without a fix one way or another, there is a potential kernel attack vector through the error reporting function of the caam driver. Cristian S. -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
