On Fri, 2014-08-01 at 22:18 +0800, Herbert Xu wrote: > On Wed, Jul 23, 2014 at 09:07:45AM -0700, Tim Chen wrote: > > On Wed, 2014-07-23 at 21:09 +0800, Herbert Xu wrote: > > > On Thu, Jul 10, 2014 at 04:18:08PM -0700, Tim Chen wrote: > > > > For the special case when we have a null input string, we want > > > > to initialize the entry len to 0 for the hash/ahash walk, so > > > > cyrpto_hash_walk_last will return the correct result indicating > > > > that we have completed the scatter list walk. Otherwise we may > > > > keep walking the sg list and access bogus memory address. > > > > > > > > Signed-off-by: Tim Chen <tim.c.chen@xxxxxxxxxxxxxxx> > > > > > > Sorry but which driver is broken by this? > > > > > > > I haven't tested other driver, but I see this problem when > > I was testing the new multi-buffer sha1 driver > > OK, I'll add this patch along with the rest of your series then. > I thought it affected existing drivers but it seems that it's > only your driver that's affected. > > Thanks, Thanks Herbert. I was out on vacation for a while. Wonder if you are planning to pick up the multi-buffer SHA1 series for 3.17 kernel? Tim -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html