Hi Horia, On 10.08.2014 11:57, Horia Geantă wrote: > On 8/8/2014 2:27 PM, Cristian Stoica wrote: > Don't add more checkpatch warnings on top of existing ones. I've weighted all the checkpatch warnings and errors introduced by these patches and I've found them fair versus Linux coding style guide. If these are the only barriers to acceptance then I'll consider an update if Herbert agrees with the patches: > WARNING: line over 80 characters > #58: FILE: crypto/testmgr.c:992: > >> + crypto_ablkcipher_set_flags(tfm, CRYPTO_TFM_REQ_WEAK_KEY); This line is 82 chars long. I find it slightly more readable than the alternative[s]. "The limit on the length of lines is 80 columns and this is a strongly preferred limit [...] unless exceeding 80 columns significantly increases readability and does not hide information" Now this is a debate about "slightly" vs "significantly". Have fun. Cristian S. -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
