Re: [PATCH 0/9] crypto: caam - Add RTA descriptor creation library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 18 Jul 2014 19:37:17 +0300
Horia Geanta <horia.geanta@xxxxxxxxxxxxx> wrote:

> This patch set adds Run Time Assembler (RTA) SEC descriptor library.
> 
> The main reason of replacing incumbent "inline append" is
> to have a single code base both for user space and kernel space.

that's orthogonal to what this patchseries is doing from the kernel
maintainer's perspective:  it's polluting the driver with a
CodingStyle-violating (see, e.g., Chapter 12) 6000+ lines of code -
which can only mean it's slower and more susceptible to bugs - and
AFAICT for no superior technical advantage:  NACK from me.

Kim
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux