On Mon, Jun 23, 2014 at 09:11:29AM +0200, Stephan Mueller wrote: > As reported by a static code analyzer, the code for the ordering of > the linked list can be simplified. > > Reported-by: kbuild test robot <fengguang.wu@xxxxxxxxx> > Signed-off-by: Stephan Mueller <smueller@xxxxxxxxxx> > --- > crypto/drbg.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/crypto/drbg.c b/crypto/drbg.c > index faaa2ce..99fa8f8 100644 > --- a/crypto/drbg.c > +++ b/crypto/drbg.c > @@ -516,13 +516,13 @@ static int drbg_ctr_df(struct drbg_state *drbg, > S2.next = addtl; > > /* > - * splice in addtl between S2 and S4 -- we place S4 at the end of the > - * input data chain > + * Splice in addtl between S2 and S4 -- we place S4 at the end > + * of the input data chain. As this code is only triggered when > + * addtl is not NULL, no NULL checks are necessary. > */ > tempstr = addtl; > - for (; NULL != tempstr; tempstr = tempstr->next) > - if (NULL == tempstr->next) > - break; > + while (tempstr->next) > + tempstr = tempstr->next; > tempstr->next = &S4; This is still broken. -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
