On Fri, May 30, 2014 at 01:33:06PM +0000, Hsieh, Che-Min wrote: > > It is nice to know that the request queue is per tfm. We are currently on android-3.10. I believe all the drivers under drivers/crypto/ don't follow this rule. At the minimum, our driver qcrypto does not. Other than backlogging function, does it break anything? How critical is it to fix the driver soon? Sorry I don't know what I was smoking when I said that but it's bollocks :) Marek is quite correct that MAY_BACKLOG users can indefinitely add to the backlog queue. However, it is meant to be limited to one entry per-tfm. This is because the user is supposed to back off once they get EBUSY, until they're notified once the backlog entry is popped off (but not processed, it must be resubmitted). We don't really do any checking right now as there aren't many MAY_BACKLOG users. But if it becomes a problem we can always add a check to ensure each tfm does not add more than one backlog request. Cheers, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
