On Tue, May 27, 2014 at 10:28:55AM -0700, Eric Dumazet wrote: > From: Eric Dumazet <edumazet@xxxxxxxxxx> > > zswap allocates one LZO context per online cpu. > > Using vmalloc() for small (16KB) memory areas has drawback of slowing > down /proc/vmallocinfo and /proc/meminfo reads, TLB pressure and poor > NUMA locality, as default NUMA policy at boot time is to interleave > pages : > > edumazet:~# grep lzo /proc/vmallocinfo | head -4 > 0xffffc90006062000-0xffffc90006067000 20480 lzo_init+0x1b/0x30 pages=4 vmalloc N0=2 N1=2 > 0xffffc90006067000-0xffffc9000606c000 20480 lzo_init+0x1b/0x30 pages=4 vmalloc N0=2 N1=2 > 0xffffc9000606c000-0xffffc90006071000 20480 lzo_init+0x1b/0x30 pages=4 vmalloc N0=2 N1=2 > 0xffffc90006071000-0xffffc90006076000 20480 lzo_init+0x1b/0x30 pages=4 vmalloc N0=2 N1=2 > > This patch tries a regular kmalloc() and fallback to vmalloc in case > memory is too fragmented. > > Signed-off-by: Eric Dumazet <edumazet@xxxxxxxxxx> Looks good to me. This would seem like something that could be generalised to other vmalloc users, no? Thanks, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
