Re: [PATCH] crypto:caam - Define setbits32() and clrbits32() for ARM in the Freescale CAAM driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thursday, May 01, 2014 at 10:46:50 PM, Kim Phillips wrote:
> On Tue, 29 Apr 2014 15:41:39 +0530
> 
> Ruchika Gupta <ruchika.gupta@xxxxxxxxxxxxx> wrote:
> > The kernel defines setbits32() and clrbits32() macros only for
> > Power-based architectures.  This patch modifies the Freescale CAAM
> > driver to add macros for use on ARM architectures.
> > 
> > Signed-off-by: Victoria Milhoan <vicki.milhoan@xxxxxxxxxxxxx>
> > Signed-off-by: Ruchika Gupta <ruchika.gupta@xxxxxxxxxxxxx>
> > ---
> 
> Add these macros to arch/arm's io.h instead of duplicating their
> definitions in drivers such as caam.

I'd rather see the driver not using such ad-hoc stuff at all. Instead, it should 
just implement the r-m-w itself.

Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux