Re: [PATCH] crypto: s5p-sss: fix multiplatform build

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Friday, May 09, 2014 8:36 PM, Arnd Bergmann wrote:
> 
> As we are preparing to enable multiplatform support on EXYNOS,
> we can no longer include mach/*.h or plat/*.h headers from device
> drivers.
> 
> The s5p-sss driver was just enabled for EXYNOS when it used to
> be used only on s5pv210, and it includes two samsung platform
> specific header files for historic reasons. Fortunately, it no
> longer actually needs them, so we can remove the #includes and
> avoid the problem
> 
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> Cc: Naveen Krishna Chatradhi <ch.naveen@xxxxxxxxxxx>
> Cc: Tomasz Figa <t.figa@xxxxxxxxxxx>
> Cc: <linux-samsung-soc@xxxxxxxxxxxxxxx>
> Cc: Vladimir Zapolskiy <vz@xxxxxxxxx>
> Cc: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>

I checked that these machine specific headers are
unnecessary. Thanks!

Reviewed-by: Jingoo Han <jg1.han@xxxxxxxxxxx>

Best regards,
Jingoo Han

> ---
> Please apply on top of the other s5p-sss patches
> 
> diff --git a/drivers/crypto/s5p-sss.c b/drivers/crypto/s5p-sss.c
> index 47c568e..4197ad9 100644
> --- a/drivers/crypto/s5p-sss.c
> +++ b/drivers/crypto/s5p-sss.c
> @@ -30,9 +30,6 @@
>  #include <crypto/aes.h>
>  #include <crypto/ctr.h>
> 
> -#include <plat/cpu.h>
> -#include <mach/dma.h>
> -
>  #define _SBF(s, v)                      ((v) << (s))
>  #define _BIT(b)                         _SBF(b, 1)
> 
> 
> --

--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux