Implement fast-path error code printout for errors with no associated
handler function. This reduces calls to this kmalloc() nonsense in
SPRINTFCAT() already.
Note that the format of output is compatible with the old code, even
if -- exposed like this -- it looks a bit weird. Checkpatch complains
on this one as well.
Signed-off-by: Marek Vasut <marex@xxxxxxx>
Cc: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Cc: Horia Geanta <horia.geanta@xxxxxxxxxxxxx>
---
drivers/crypto/caam/error.c | 12 ++++++++++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/drivers/crypto/caam/error.c b/drivers/crypto/caam/error.c
index 3d7be4c..961331d 100644
--- a/drivers/crypto/caam/error.c
+++ b/drivers/crypto/caam/error.c
@@ -265,10 +265,18 @@ void caam_jr_strstatus(struct device *jrdev, u32 status)
};
u32 ssrc = status >> JRSTA_SSRC_SHIFT;
+ /*
+ * If there is no further error handling function, just
+ * print the error code, error string and exit.
+ */
+ if (!status_src[ssrc].report_ssed) {
+ dev_err(jrdev, "%08x: %s: \n", status, status_src[ssrc].error);
+ return;
+ }
+
sprintf(outstr, "%s: ", status_src[ssrc].error);
- if (status_src[ssrc].report_ssed)
- status_src[ssrc].report_ssed(status, outstr);
+ status_src[ssrc].report_ssed(status, outstr);
dev_err(jrdev, "%08x: %s\n", status, outstr);
}
--
1.9.2
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
