Re: [PATCH 2/2] crypto: bfin_crc: avoid get physical address of coherence memory by dma_map_single

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Herbert,

Could you please review this patch?

Thanks

Sonic Zhang


On Thu, Apr 10, 2014 at 5:02 PM, Marek Vasut <marex@xxxxxxx> wrote:
> On Thursday, April 10, 2014 at 10:40:59 AM, Sonic Zhang wrote:
>> From: Sonic Zhang <sonic.zhang@xxxxxxxxxx>
>>
>> - The 4-byte sg_mid_buf is located in the middle of the coherence memory
>> sg_cpu. Don't call dma_map_single to get its physical address. Get the its
>> base physical address from the physical address of sg_cpu instead.
>> - Should set up the dma descriptor data after the 4-byte sg_mid_buf is
>> filled in completely from next sg buffer.
>> - memory copy from sg buffer should be done via virtual address.
>> - Remove unused reference to blackfin header
>>
>> Signed-off-by: Sonic Zhang <sonic.zhang@xxxxxxxxxx>
>
> I don't see any obvious problems,
>
> Reviewed-by: Marek Vasut <marex@xxxxxxx>
>
> Best regards,
> Marek Vasut
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux