On Friday, April 11, 2014 at 11:30:25 AM, Sonic Zhang wrote:
> From: Sonic Zhang <sonic.zhang@xxxxxxxxxx>
>
> in case of multiple crc devices are probed.
> Call platform_set_drvdata() before adding new CRC device into the list.
>
> Signed-off-by: Sonic Zhang <sonic.zhang@xxxxxxxxxx>
> ---
> v3-change:
> - check list_is_singular() before register the algorithm
>
> drivers/crypto/bfin_crc.c | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/crypto/bfin_crc.c b/drivers/crypto/bfin_crc.c
> index cea3e8c..892b6d2 100644
> --- a/drivers/crypto/bfin_crc.c
> +++ b/drivers/crypto/bfin_crc.c
> @@ -665,19 +665,19 @@ static int bfin_crypto_crc_probe(struct
> platform_device *pdev) if (timeout == 0)
> dev_info(&pdev->dev, "init crc poly timeout\n");
>
> + platform_set_drvdata(pdev, crc);
> +
> spin_lock(&crc_list.lock);
> list_add(&crc->list, &crc_list.dev_list);
> spin_unlock(&crc_list.lock);
>
> - platform_set_drvdata(pdev, crc);
> -
> - ret = crypto_register_ahash(&algs);
> - if (ret) {
> - spin_lock(&crc_list.lock);
> - list_del(&crc->list);
> - spin_unlock(&crc_list.lock);
> - dev_err(&pdev->dev, "Cann't register crypto ahash device\n");
> - goto out_error_dma;
> + if (list_is_singular(&crc_list.dev_list)) {
> + ret = crypto_register_ahash(&algs);
> + if (ret) {
> + dev_err(&pdev->dev,
> + "Cann't register crypto ahash device\n");
"Cann't" with two Ns ;-/
Well, add "Reviewed-by: Marek Vasut <marex@xxxxxxx>" into the next go please :)
Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
