Re: [PATCH V2] crypto: omap-des - use devm_ioremap_resource()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 04/07/2014 11:54 PM, Jingoo Han wrote:
> Use devm_ioremap_resource() because devm_request_and_ioremap() is
> obsoleted by devm_ioremap_resource().
> 
> Signed-off-by: Jingoo Han <jg1.han@xxxxxxxxxxx>
> ---
> Changes since v1:
> - remove unnecessary error message, because devm_ioremap_resource()
>   already prints one in all failure cases.
> 
>  drivers/crypto/omap-des.c |    7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/crypto/omap-des.c b/drivers/crypto/omap-des.c
> index ec5f131..4a13624 100644
> --- a/drivers/crypto/omap-des.c
> +++ b/drivers/crypto/omap-des.c
> @@ -1074,10 +1074,9 @@ static int omap_des_probe(struct platform_device *pdev)
>  	if (err)
>  		goto err_res;
>  
> -	dd->io_base = devm_request_and_ioremap(dev, res);
> -	if (!dd->io_base) {
> -		dev_err(dev, "can't ioremap\n");
> -		err = -ENOMEM;
> +	dd->io_base = devm_ioremap_resource(dev, res);
> +	if (IS_ERR(dd->io_base)) {
> +		err = PTR_ERR(dd->io_base);
>  		goto err_res;
>  	}
>  	dd->phys_base = res->start;
> 


Acked-by: Joel Fernandes <joelf@xxxxxx>

Thanks,

-Joel

--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux