Hi Srini, Thanks for the comments. On 04/04/2014 12:23 PM, Srinivas Kandagatla wrote: > > Minor nitpicks. > > On 03/04/14 17:17, Stanimir Varbanov wrote: >> +#define REQ_SIZE 17 /* bit 20-17 */ > > I would have defined macros like this with _SHIFT at the end, something > like this: > > #define REQ_SIZE_SHIFT 17 sure, I will add _SHIFT suffix to all places where it is applicable. > >> +#define REQ_SIZE_MASK (0xf << REQ_SIZE) > You could possibly use GENMASK macro for this, its much readable, in > *some cases* it could reduce few more lines in header too. > > #define REQ_SIZE_MASK GENMASK(20, 17) > > > My comments are equally applicable to most macros in this header file. yes, right will do. Thanks. regards, Stan -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
