On Thu, Mar 27, 2014 at 12:29:00PM +0100, Ard Biesheuvel wrote: > The GHASH setkey() function uses SSE registers but fails to call > kernel_fpu_begin()/kernel_fpu_end(). Instead of adding these calls, and > then having to deal with the restriction that they cannot be called from > interrupt context, move the setkey() implementation to the C domain. Note that setkey cannot be called from interrupt context since allocation/setkey is supposed to be slow-path material. But your approach is fine by me. > Note that setkey() does not use any particular SSE features and is not > expected to become a performance bottleneck. > > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx> > --- > > I suppose this should be marked for stable as well? Sure I'll add the cc. Thanks, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
