On 24 March 2014 18:29, chandramouli narayanan <mouli@xxxxxxxxxxxxxxx> wrote: > On Mon, 2014-03-24 at 17:10 +0100, Mathias Krause wrote: >> The recent addition of the AVX2 variant of the SHA1 hash function wrongly >> disabled the AVX variant by introducing a flaw in the feature test. Fixed >> in patch 1. >> >> The alignment calculations of the AVX2 assembler implementation are >> questionable, too. Especially the page alignment of the stack pointer is >> broken in multiple ways. Fixed in patch 2. In patch 3 another issue for >> code alignment is fixed. >> >> Please apply! >> >> Mathias Krause (3): >> crypto: x86/sha1 - re-enable the AVX variant >> crypto: x86/sha1 - fix stack alignment of AVX2 variant >> crypto: x86/sha1 - reduce size of the AVX2 asm implementation >> >> arch/x86/crypto/sha1_avx2_x86_64_asm.S | 8 ++------ >> arch/x86/crypto/sha1_ssse3_glue.c | 26 ++++++++++++++++---------- >> 2 files changed, 18 insertions(+), 16 deletions(-) >> > Your fixes are the right on mark. I went through your patches and tested > them and found to be correct. Thanks for double-checking! > Sorry for causing regression and missing alignment issues in the patches > I submitted. No problem with that. But as I'm not subscribed to the linux-crypto mailing list I haven't seen your earlier submissions. Otherwise I would have objected earlier. ;) Thanks, Mathias -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
