On Wednesday, March 12, 2014 at 07:47:43 PM, chandramouli narayanan wrote: > This git patch adds x86_64 AVX2 optimization of SHA1 transform > to crypto support. The patch has been tested with 3.14.0-rc1 > kernel. > > On a Haswell desktop, with turbo disabled and all cpus running > at maximum frequency, tcrypt shows AVX2 performance improvement > from 3% for 256 bytes update to 16% for 1024 bytes update over > AVX implementation. > > Signed-off-by: Chandramouli Narayanan <mouli@xxxxxxxxxxxxxxx> > > diff --git a/arch/x86/crypto/sha1_avx2_x86_64_asm.S > b/arch/x86/crypto/sha1_avx2_x86_64_asm.S new file mode 100644 > index 0000000..2f71294 > --- /dev/null > +++ b/arch/x86/crypto/sha1_avx2_x86_64_asm.S > @@ -0,0 +1,732 @@ > +/* > + Implement fast SHA-1 with AVX2 instructions. (x86_64) > + > + This file is provided under a dual BSD/GPLv2 license. When using or > + redistributing this file, you may do so under either license. > + > + GPL LICENSE SUMMARY Please see Documentation/CodingStyle chapter 8 for the preffered comment style. [...] > +*/ > + > +#--------------------- > +# > +#SHA-1 implementation with Intel(R) AVX2 instruction set extensions. DTTO here. > +#This implementation is based on the previous SSSE3 release: > +#Visit http://software.intel.com/en-us/articles/ > +#and refer to improving-the-performance-of-the-secure-hash-algorithm-1/ > +# > +#Updates 20-byte SHA-1 record in 'hash' for even number of > +#'num_blocks' consecutive 64-byte blocks > +# > +#extern "C" void sha1_transform_avx2( > +# int *hash, const char* input, size_t num_blocks ); > +# > + > +#ifdef CONFIG_AS_AVX2 I wonder, is this large #ifdef around the entire file needed here? Can you not just handle not-compiling this file in in the Makefile ? [...] > + push %rbx > + push %rbp > + push %r12 > + push %r13 > + push %r14 > + push %r15 > + #FIXME: Save rsp > + > + RESERVE_STACK = (W_SIZE*4 + 8+24) > + > + # Align stack > + mov %rsp, %rbx > + and $(0x1000-1), %rbx > + sub $(8+32), %rbx > + sub %rbx, %rsp > + push %rbx > + sub $RESERVE_STACK, %rsp > + > + avx2_zeroupper > + > + lea K_XMM_AR(%rip), K_BASE Can you please use TABs for indent consistently (see the CodingStyle again) ? [...] > + .align 32 > + _loop: > + # code loops through more than one block > + # we use K_BASE value as a signal of a last block, > + # it is set below by: cmovae BUFFER_PTR, K_BASE > + cmp K_BASE, BUFFER_PTR > + jne _begin > + .align 32 > + jmp _end > + .align 32 > + _begin: > + > + # Do first block > + RR 0 > + RR 2 > + RR 4 > + RR 6 > + RR 8 > + > + jmp _loop0 > +_loop0: > + > + RR 10 > + RR 12 > + RR 14 > + RR 16 > + RR 18 > + > + RR 20 > + RR 22 > + RR 24 > + RR 26 > + RR 28 Can you not generate these repeated sequences with some of the AS's macro voodoo ? Like .rept or somesuch ? [...] > +.macro UPDATE_HASH hash, val > + add \hash, \val > + mov \val, \hash > +.endm This macro is defined below the point where it's used, which is a little counter-intuitive. [...] > + > +/* AVX2 optimized implementation: > + * extern "C" void sha1_transform_avx2( > + * int *hash, const char* input, size_t num_blocks ); What does this comment tell me ? btw. you might want to squash 1/2 and 2/2 , since they are not two logical separate blocks I think. -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
