On Wednesday, March 12, 2014 at 01:11:01 PM, Herbert Xu wrote: > On Mon, Mar 03, 2014 at 01:21:48AM +0100, Marek Vasut wrote: > > -static void ahash_def_finup_done2(struct crypto_async_request *req, int > > err) +static void ahash_def_finup_done2(struct crypto_async_request > > *areq, int err) > > Please keep the existing name to be consistent with the rest > of the crypto API code. You should also use the same name in > your second patch for consistency. Done. Moreover, the original code this patch changes still has a bug I think. The invocation of areq->base.complete() is wrong in the original code here. I will post V3 of the patches where I explain the problem in detail. Best regards, Marek Vasut -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
