RE: [PATCH 2/2] Crypto: Add support for 192 & 256 bit keys to AESNI RFC4106 - fixed whitespace

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2014-03-07 at 19:40 -0600, McCaffrey, Timothy M wrote:
> You need to set the key length in the aes_key_expanded structure either explicitly or use the aesni_set_key function.
> 
> The asm code expects only valid values in the structure (16, 24 or 32).
> 
> If the encrypt/decrypt is called without setting the key, you get garbage (and an error in this case).  Perhaps the glue code needs to double check the keysize before calling the asm code?
> 
> 	- Tim
> 

Right, your new function actually will look for the keylen which was not
needed before.  

I think it will be a good idea to double check the keysize has valid
value before calling the asm code or in the asm code itself. 

Tim


--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux