On Sat, 2014-02-15 at 09:23 +0800, Herbert Xu wrote: > On Fri, Feb 14, 2014 at 11:14:37AM -0800, Tim Chen wrote: > > We added the soft module dependency of various crypto algorithm's module alias > > to generic crypto algorithm's module. This loads hardware accelerated > > modules and uses them when available. > > > > Signed-off-by: Tim Chen <tim.c.chen@xxxxxxxxxxxxxxx> > > I don't see the point of this patch. Any users of these modules > would be requesting for their alias and not their real name. So > either it'll already load all the hardware modules or it won't load > the generic version either. > > For example, if you request blowfish you'll get every module that > has the alias blowfish. As the software version is called blowfish_generic > it will be treated no differently than any hardware accelerated > version. If we issue an explicit modprobe of the module alias, I don't think there is a problem. I am under the impression we may have a scenario like this: Module A selects CRYPTO_ALG_B in config, which causes the generic ALG_B to get built and a module dependency to the generic ALG_B to be established. Then when module A loads, we will load the generic ALG_B module. So a soft dependency in the generic ALG_B module is needed to load all the other alias module along with the generic module. Otherwise only the generic module is loaded when module A loads. Tim -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
