On Tue, Jan 14, 2014 at 06:31:01PM +0100, Marek Vasut wrote: > Move the AES operation type and mode from async crypto context to > crypto request context. This allows for recycling of the async crypto > context for different kinds of operations. > > I found this problem when I used dm-crypt, which uses the same async > crypto context (actx) for both encryption and decryption requests. > Since the requests are enqueued into the processing queue, immediatelly > storing the type of operation into async crypto context (actx) caused > corruption of this information when encryption and decryption operations > followed imediatelly one after the other. When the first operation was > dequeued, the second operation was already enqueued and overwritten the > type of operation in actx, thus causing incorrect result of the first > operation. > > Fix this problem by storing the type of operation into the crypto request > context. > > Signed-off-by: Marek Vasut <marex@xxxxxxx> > Cc: David S. Miller <davem@xxxxxxxxxxxxx> > Cc: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx> > Cc: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> > Cc: Shawn Guo <shawn.guo@xxxxxxxxxx> > Cc: Tom Lendacky <thomas.lendacky@xxxxxxx> Patch applied. -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html