Re: [PATCH 3/8 v4] crypto:s5p-sss: Add support for SSS module on Exynos

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Naveen,

On 15.01.2014 10:15, Naveen Krishna Chatradhi wrote:
This patch adds new compatible and variant struct to support the SSS
module on Exynos4 (Exynos4210), Exynos5 (Exynos5420 and Exynos5250)
for which
1. AES register are at an offset of 0x200 and
2. hash interrupt is not available
[snip]
  Required properties:

  - compatible : Should contain entries for this and backward compatible
    SSS versions:
    - "samsung,s5pv210-secss" for S5PV210 SoC.
+  - "samsung,exynos4210-secss" for Exynos4210, Exynos4212, Exynos4412, Exynos5250,
+		Exynos5260 and Exynos5420 SoCs.
  - reg : Offset and length of the register set for the module
  - interrupts : the interrupt-specifier for the SSS module.
-		Two interrupts "feed control and hash" in case of S5PV210
-- clocks : the required gating clock for the SSS module.
-- clock-names : the gating clock name to be requested in the SSS driver.
+		-- Two interrupts "feed control and hash" in case of
+		   "samsung,s5pv210-secss"
+		-- One interrupts "feed control" in case of
+		   "samsung,exynos4210-secss".
+- clocks : list of clock phandle and specifier pairs for all clocks  listed in
+		clock-names property.
+- clock-names : list of device clock input names; should contain one entry
+		"secss".

Hmm, I guess this is a rebase error, because this should rather be squashed with patch 2/8.

Otherwise the patch looks good to me.

Best regards,
Tomasz
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux