Rafael Aquini wrote: > This patch introduces changes to the random_write method so it can split the > given seed and completely stir the output pools with different halves of it, > when seed lenght allows us doing so. > > - ret = write_pool(&blocking_pool, buffer, count); > + ret = write_pool(pool1, buffer, count1); > if (ret) > return ret; > - ret = write_pool(&nonblocking_pool, buffer, count); > + ret = write_pool(pool2, buffer + offset, count2); Doesn't this assume that both halves of the buffer contain some (uncredited) entropy? In other words, wouldn't this result in worse randomness for pool2 if the second half of the buffer contains just zero padding? Regards, Clemens -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html