On 11/25/2013 04:15 PM, Richard Weinberger wrote: > On Fri, Nov 22, 2013 at 7:02 AM, Yuanhan Liu > <yuanhan.liu@xxxxxxxxxxxxxxx> wrote: >> Greetings, >> >> I got the below dmesg and the first bad commit is >> >> commit 20545536cd8ea949c61527b6395ec8c0d2c237b1 >> Author: Boaz Harrosh <bharrosh@xxxxxxxxxxx> >> Date: Thu Jul 19 15:22:37 2012 +0300 >> >> RFC: do_xor_speed Broken on UML do to jiffies >> >> Remember that hang I reported a while back on UML. Well >> I'm at it again, and it still hangs and I found why. >> >> I have dprinted jiffies and it never advances during the >> loop at do_xor_speed. There for it is stuck in an endless >> loop. I have also dprinted current_kernel_time() and it >> returns the same constant value as well. >> >> Note that it does usually work on UML, only during >> the modprobe of xor.ko while that test is running. It looks >> like some lucking is preventing the clock from ticking. >> >> However ktime_get_ts does work for me so I changed the code >> as below, so I can work. See how I put several safety >> guards, to never get hangs again. >> And I think my time based approach is more accurate then >> previous system. >> >> UML guys please investigate the jiffies issue? what is >> xor.ko not doing right? > > This patch never hit my mailbox... > >> Signed-off-by: Boaz Harrosh <bharrosh@xxxxxxxxxxx> >> Sir Richard I never followed on this patch. Sorry. I do think it is in the right direction, but it has a dev-by-zero problem and a 32 bitness problem. (So I never sent it, beyond the initial query) [It stopped to be very important for me since I stopped using UM very much. Ever since FC17 I'm unable to produce a running image. It just will not boot, an image that a kvm would. So very sad me, but no UML for me anymore.] If you want to investigate. try doing a modprobe xor.ko on a uml and see. since xor.ko is only built on demand for example enabling exofs or object-layout-driver will select it. ,or MD-raid5. Thanks Boaz -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
