On Thu, Nov 14, 2013 at 05:10:20PM +0100, Jan Glauber wrote: > On Thu, Oct 31, 2013 at 11:25:47AM +0800, Herbert Xu wrote: > > Hi: > > Hi Herbert, > > just seen this as my old email address is dead... Your patch looks > fine as it keeps the iv and the key together as required by the instruction. Thanks for reviewing. > However, I'm curious how this could be racy with threads. The encryption must > be serialized because of the chaining. The decryption could in theory happen > in parallel, but is this the case here? A single tfm can be used by multiple threads in parallel. For example, two packets of the same IPsec SA may be processed by two CPUs at the same time. This applies both inbound and outbound so it affects both encryption and decryption. Cheers, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
