On Sat, Oct 19, 2013 at 08:13:25PM -0300, Geyslan Gregório Bem wrote: > > I can understand you. You don't want to break your git history > (blame). But when a code is clearly more readable/understandable you > must assume that it has a huge net-positive. > > The patch improves the code in three ways: > - Only one if/else; > - Not blame on static analysis tools. > - And avoid more discussion about that in the future (nobody will send > patches like this to disturb you about that part of code). > > The decision is yours. FWIW I totally agree with David so your patch isn't going in. Sorry. -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
