This series removes the code duplication of authenc key parsing by introducing a common helper function crypto_authenc_extractkeys() in patch 1. Patches 2 to 5 change all remaining places to use the new helper. Patches 3 and 4 also fix potential memory corruptions by ensuring the supplied keys won't overflow there respective buffers. I was unable to test patches 3 to 5 as I don't have the needed hardware for these devices -- not even a cross compiler for those architectures. In case patches 3 and 4 are enqueued for stable, patch 1 needs to be as well, as it's a prerequisite for those. Please apply! Mathias Krause (5): crypto: authenc - Export key parsing helper function crypto: authencesn - Simplify key parsing crypto: ixp4xx - Simplify and harden key parsing crypto: picoxcell - Simplify and harden key parsing crypto: talitos - Simplify key parsing crypto/authenc.c | 48 +++++++++++++++++++++++-------------- crypto/authencesn.c | 26 +++----------------- drivers/crypto/ixp4xx_crypto.c | 26 +++++++------------- drivers/crypto/picoxcell_crypto.c | 32 ++++++------------------ drivers/crypto/talitos.c | 35 ++++++-------------------- include/crypto/authenc.h | 12 ++++++++- 6 files changed, 70 insertions(+), 109 deletions(-) -- 1.7.2.5 -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html