Hi Ard, On Thu, Oct 03, 2013 at 10:59:23PM +0100, Ard Biesheuvel wrote: > Note to reviewers: > Reviewing the file aesbs-core.S may be a bit overwhelming, so if there are any > questions or concerns, please refer the file bsaes-armv7.pl which can be found > at the link below. This is the original Perl script that gets called by > OpenSSL's build system during their build to generate the .S file on the fly. > [In the case of OpenSSL, this is used in some cases to target different > assemblers or ABIs]. This arrangement is not suitable (or required) for the > kernel, so I have taken the generated .S file instead. > > http://git.openssl.org/gitweb/?p=openssl.git;a=commit;h=6f6a6130 > > This series still depends on commit a62b01cd (crypto: create generic version of > ablk_helper) which I omitted this time but which can be found in the cryptodev > tree or in linux-next. Why do you consider it unsuitable to ship the perl script with the kernel? Perl 5 is already documented as a build dependency in Documentation/Changes and I'd *much* rather the .S file was generated rather than shipped and hacked. That amount of opaque assembly code for something like crypto feels really dangerous from both a review and a maintenance perspective. Will -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
