Re: [PATCH] ansi_cprng: Fix off by one error in non-block size request

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Sep 17, 2013 at 08:33:11AM -0400, Neil Horman wrote:
> Stephan Mueller reported to me recently a error in random number generation in
> the ansi cprng. If several small requests are made that are less than the
> instances block size, the remainder for loop code doesn't increment
> rand_data_valid in the last iteration, meaning that the last bytes in the
> rand_data buffer gets reused on the subsequent smaller-than-a-block request for
> random data.
> 
> The fix is pretty easy, just re-code the for loop to make sure that
> rand_data_valid gets incremented appropriately
> 
> Signed-off-by: Neil Horman <nhorman@xxxxxxxxxxxxx>
> Reported-by: Stephan Mueller <stephan.mueller@xxxxxxxxx>
> CC: Stephan Mueller <stephan.mueller@xxxxxxxxx>
> CC: Petr Matousek <pmatouse@xxxxxxxxxx>
> CC: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
> CC: "David S. Miller" <davem@xxxxxxxxxxxxx>

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux