On 09/13/2013 06:23 AM, Herbert Xu wrote: > On Mon, Sep 09, 2013 at 10:02:04AM -0600, Stephen Warren wrote: >> On 09/09/2013 01:35 AM, Linus Walleij wrote: >>> The way I read the Tegra AES RNG is that it has a homebrew >>> algorithm for initializing the 128bit RNG using timespec and >>> the unique chip ID. This looks like reinventing the (square) >>> wheel, instead just grab 128bits from the kernel entropy pool >>> where the time and (after another patch) chip unique ID is >>> already mixed in. >>> >>> Incidentally this also gets rid of a rather ugly >>> cross-dependence on the machine using an extern declaration. >> >> This sounds reasonable to me, although I know little about the driver. >> Varun, can you please comment? >> >> Acked-by: Stephen Warren <swarren@xxxxxxxxxx> > > Patch applied. Thanks. I'm curious which kernel version it was merged for; it'd be nice to remove tegra_chip_uid() from the Tegra tree now since it's unused, but that obviously requires this patch in the history. -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
