Please don't trim cc lists! James Yonan <james@xxxxxxxxxxx> wrote: > > I tried this patch, but I still see an apparent module lookup/load race > if code on several CPUs calls crypto_alloc_aead at the same time, and an > external module such as aes needs to be loaded. > > Seeing this in the log: "request_module: runaway loop modprobe gcm(aes)" > > Shouldn't module lookup/load be bracketed by some sort of lock to > prevent this? This sounds like a different problem. Larvals are only used to control the instantiation of templates. The loading of modules occur prior to that so you can certainly have multiple loads occur if multiple threads are trying to allocate the same algorithm. This should be harmless since gcm(aes) doesn't exist anyway so regardless of whether we load the module the lookup will fail and we will go through the larval code path. Cheers, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
