Should I resend a fixed version with (1U << 27) - 1) instead ? Best, JS On Thursday 15 August 2013 14:01:50 Jan-Simon Möller wrote: > Hi all, > > please merge the attached patch. > > Fix for warning: > linux/crypto/fcrypt.c:143:47: warning: signed shift result (0x598000000) > requires 36 bits to > represent, but 'int' only has 32 bits [-Wshift-overflow] > Z(0xef), Z(0x70), Z(0xcf), Z(0xc2), Z(0x2a), Z(0xb3), Z(0x61), > Z(0xad), > ^~~~~~~ > linux/crypto/fcrypt.c:113:29: note: expanded from macro 'Z' > #define Z(x) cpu_to_be32((x << 27 ) | (x >> 5)) > ^ ~~ > linux/include/uapi/linux/byteorder/little_endian.h:38:53: note: expanded > from macro > '__cpu_to_be32' > #define __cpu_to_be32(x) ((__force __be32)__swab32((x))) > ^ > linux/include/uapi/linux/swab.h:116:21: note: expanded from macro '__swab32' > ___constant_swab32(x) : \ > ^ > linux/include/uapi/linux/swab.h:18:12: note: expanded from macro > '___constant_swab32' > (((__u32)(x) & (__u32)0x0000ff00UL) << 8) | \ > ^ > > Solution - make sure we don't exceed the 32 bit range by adding (x & ~(1U << > 27)) > = & (0xF7FFFFFF)_16 or & (1111 0111 1111 1111 1111 1111 1111 1111)_2 > > > Author: PaX Team <pageexec at freemail.hu> > ML-Post: > http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20120507/142707 > .html URL: http://llvm.linuxfoundation.org > > Merge: Jan-Simon Möller <dl9pf at gmx.de> > > > > Best, -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
