On Thu, Aug 15, 2013 at 02:01:50PM +0200, Jan-Simon Möller wrote: > Hi all, > > please merge the attached patch. > > Fix for warning: > linux/crypto/fcrypt.c:143:47: warning: signed shift result (0x598000000) > requires 36 bits to > represent, but 'int' only has 32 bits [-Wshift-overflow] > Z(0xef), Z(0x70), Z(0xcf), Z(0xc2), Z(0x2a), Z(0xb3), Z(0x61), > Z(0xad), > ^~~~~~~ > linux/crypto/fcrypt.c:113:29: note: expanded from macro 'Z' > #define Z(x) cpu_to_be32((x << 27 ) | (x >> 5)) > ^ ~~ > linux/include/uapi/linux/byteorder/little_endian.h:38:53: note: expanded from > macro > '__cpu_to_be32' > #define __cpu_to_be32(x) ((__force __be32)__swab32((x))) > ^ > linux/include/uapi/linux/swab.h:116:21: note: expanded from macro '__swab32' > ___constant_swab32(x) : \ > ^ > linux/include/uapi/linux/swab.h:18:12: note: expanded from macro > '___constant_swab32' > (((__u32)(x) & (__u32)0x0000ff00UL) << 8) | \ > ^ > > Solution - make sure we don't exceed the 32 bit range by adding (x & ~(1U << > 27)) > = & (0xF7FFFFFF)_16 or & (1111 0111 1111 1111 1111 1111 1111 1111)_2 Your fix makes no sense. To achieve what you want you'd need to lop off the first 5 bits, not the fifth bit. However, which compiler is this? This warning seems to be rather pointless. Thanks, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
