On Tue, 2013-07-16 at 22:49 +0900, Tetsuo Handa wrote: > Herbert Xu wrote: > > Looks like a bug in whatever is creating the initrd as it isn't > > including modules necessary for the boot. > > It turned out that it is already wrong as of creating modules.dep. > > # grep crc /lib/modules/3.11.0-rc1/modules.dep > kernel/crypto/crct10dif.ko: > kernel/drivers/scsi/sd_mod.ko: kernel/lib/crc-t10dif.ko > kernel/lib/crc-t10dif.ko: > > modules.dep says > > (1) sd_mod.ko depends on crc-t10dif.ko > (2) crc-t10dif.ko does not depend on crct10dif.ko Yes, the generator of modules.dep does not seem to pick up the right dependency. > > but commit 2d31e518 made crc-t10dif.ko depend on crct10dif.ko , didn't it? > > crct10dif.ko need to be loaded before crc-t10dif.ko is loaded, but doing > > diff --git a/lib/Kconfig b/lib/Kconfig > index 35da513..53ee0fd 100644 > --- a/lib/Kconfig > +++ b/lib/Kconfig > @@ -68,6 +68,7 @@ config CRC_T10DIF > tristate "CRC calculation for the T10 Data Integrity Field" > select CRYPTO > select CRYPTO_CRCT10DIF > + depends on CRYPTO_CRCT10DIF Herbert, seems like modules.dep generator wants explicit - select CRYPTO_CRCT10DIF + depends on CRYPTO_CRCT10DIF But it seems to me like it should have known CRC_T10DIF needs CRYPTO_CRCT10DIF when we do select CRYPTO_CRCT10DIF Your thoughts? Thanks. Tim > help > This option is only needed if a module that's not in the > kernel tree needs to calculate CRC checks for use with the > > causes below warning. > > crypto/Kconfig:379: symbol CRYPTO_CRCT10DIF is selected by CRC_T10DIF > warning: (BLK_DEV_SD && SCSI_LPFC && SCSI_DEBUG) selects CRC_T10DIF which has unmet direct dependencies (CRYPTO_CRCT10DIF) -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
