On Tue, Feb 26, 2013 at 04:06:36PM -0700, Mark A. Greer wrote:
> On Tue, Feb 26, 2013 at 10:04:32AM -0600, agnel.joel@xxxxxxxxx wrote:
> > From: Joel A Fernandes <joelagnel@xxxxxx>
> >
> > After DMA is complete, the omap_aes_finish_req function is called as
> > a part of the done_task tasklet. During this its atomic and any calls
> > to pm functions should not assume they wont sleep.
> >
> > The patch replaces a call to pm_runtime_put_sync (which can sleep) with
> > pm_runtime_put thus fixing a kernel panic observed on AM33xx SoC during
> > AES operation.
> >
> > Tested on an AM33xx SoC device (beaglebone board).
> > To reproduce the problem, I used the tcrypt kernel module as:
> > modprobe tcrypt sec=2 mode=500
> >
> > Signed-off-by: Joel A Fernandes <joelagnel@xxxxxx>
> > Cc: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
> > Cc: David S. Miller <davem@xxxxxxxxxxxxx>
> > Cc: Mark A. Greer <mgreer@xxxxxxxxxxxxxxx>
> > ---
> > drivers/crypto/omap-aes.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/crypto/omap-aes.c b/drivers/crypto/omap-aes.c
> > index cf57866..8450bfd2 100644
> > --- a/drivers/crypto/omap-aes.c
> > +++ b/drivers/crypto/omap-aes.c
> > @@ -636,7 +636,7 @@ static void omap_aes_finish_req(struct omap_aes_dev *dd, int err)
> >
> > pr_debug("err: %d\n", err);
> >
> > - pm_runtime_put_sync(dd->dev);
> > + pm_runtime_put(dd->dev);
> > dd->flags &= ~FLAGS_BUSY;
> >
> > req->base.complete(&req->base, err);
>
> Acked-by: Mark A. Greer <mgreer@xxxxxxxxxxxxxxx>
Both patches applied. Thanks!
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
