On Thu, Oct 25, 2012 at 05:34:02PM -0700, Kevin Hilman wrote: > Hi Mark, Hi Kevin. > "Mark A. Greer" <mgreer@xxxxxxxxxxxxxxx> writes: > > > From: "Mark A. Greer" <mgreer@xxxxxxxxxxxxxxx> > > > > Convert the omap-sham crypto driver to use the > > pm_runtime API instead of the clk API. > > > > CC: Kevin Hilman <khilman@xxxxxxxxxxxxxxxxxxx> > > CC: Paul Walmsley <paul@xxxxxxxxx> > > CC: Dmitry Kasatkin <dmitry.kasatkin@xxxxxxxxx> > > Signed-off-by: Mark A. Greer <mgreer@xxxxxxxxxxxxxxx> > > I can't pretend to fully understand this driver, It looks like the > current code is doing a bit more fine-grained clock gating, and leaving > the IP clocked only when needed. > > The proposed version does a 'get' in probe and a 'put' in remove, which > means the IP will always be enabled (and thus preventing low-power > states), even when it's not in use. You're right, and what I did is wrong. I'll fix this in the next revision. Thanks, Mark -- -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
