On Thu, Oct 4, 2012 at 2:22 AM, Rusty Russell <rusty@xxxxxxxxxxxxxxx> wrote: > David Howells <dhowells@xxxxxxxxxx> writes: > >> Rusty Russell <rusty@xxxxxxxxxxxxxxx> wrote: >> >>> Right. I think we need to use different names for generated vs supplied >>> files >> >> The problem with supplied files is people who do allyesconfig, allmodconfig >> and randconfig just to test things finding that their builds break. The >> kernel build magic is not really set up to handle external files like this. I >> suppose make logic can be used to conditionally include stuff that might not >> exist. >> >>> BTW, you missed a Signed-off-by: on your "MODSIGN: Use the same digest >>> for the autogen key sig as for the module sig" patch. Please update. >> >> Done. >> >> I've also added a patch to convert the system clock to a struct tm and to >> produce a struct tm within the ASN.1 decode and then compare those rather than >> time_t values as a way to deal with the validity time overflow problem. We >> may have to be able to handle certificates that we haven't generated that >> stretch beyond 2038 (I wonder if we might find such in the UEFI key database >> for example. > > OK, cherry-picked to replace my hack. > > It's in linux-next, and I will push in the next two days. > http://git.kernel.org/?p=linux/kernel/git/rusty/linux.git;a=commit;h=a15e196c5543d1d2d7f0cd70e62351aeb1f8b871 It breaks bisect.. CC kernel/module_signing.o kernel/module_signing.c: In function ‘mod_verify_sig’: kernel/module_signing.c:21:10: error: ‘ENOKEY’ undeclared (first use in this function) kernel/module_signing.c:21:10: note: each undeclared identifier is reported only once for each function it appears in kernel/module_signing.c:22:1: warning: control reaches end of non-void function [-Wreturn-type] make[1]: *** [kernel/module_signing.o] Error 1 make: *** [kernel] Error 2 make: *** Waiting for unfinished jobs.... > Thanks, > Rusty. > -- > To unsubscribe from this list: send the line "unsubscribe linux-crypto" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
