On Wed, 26 Sep 2012 12:52:11 +0800 Gao feng <gaofeng@xxxxxxxxxxxxxx> wrote: > struct netlink_dump_control c = { > .dump = inet_diag_dump_compat, > + .done = netlink_dump_done, > + .module = THIS_MODULE, > }; Since these are immutable, why the netlink_dump_control structures on the stack (which requires code to generate at runtime), and instead make them global static const struct netlink_dump_control unix_diag_ctrl = { ... -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html