于 2012年09月26日 15:07, Eric Dumazet 写道: > On Wed, 2012-09-26 at 12:52 +0800, Gao feng wrote: > >> +int netlink_dump_done(struct netlink_callback *cb) >> +{ >> + if (cb->module) >> + module_put(cb->module); >> + return 0; >> +} >> +EXPORT_SYMBOL(netlink_dump_done); >> + > > No need to test cb->module being not NULL > > > int netlink_dump_done(struct netlink_callback *cb) > { > module_put(cb->module); > return 0; > } > > Same remark for try_module_get() call > will fix it in v2 patchset. thanks Eric. -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html