On Mon, 16 Jul 2012 12:07:16 +0800 Qiang Liu <qiang.liu@xxxxxxxxxxxxx> wrote: > drivers/crypto/Kconfig | 9 + > drivers/crypto/talitos.c | 410 +++++++++++++++++++++++++++++++++++++++++++ > drivers/crypto/talitos.h | 53 ++++++ > drivers/dma/fsldma.c | 436 +++++++++++++++++++++++++--------------------- > drivers/dma/fsldma.h | 1 + > 5 files changed, 708 insertions(+), 201 deletions(-) Given the pending talitos patches, this patchseries doesn't apply cleanly: can you rebase onto [1], which is based on Herbert's cryptodev tree and contain's Horia's four patches? They didn't get any negative comments, so I assume eventually they will be applied, and doing so will make Herbert's life easier. I applied the series on Herbert's cryptodev, and while fsldma already had this build warning: drivers/dma/fsldma.c: In function 'fsl_dma_tx_submit': drivers/dma/fsldma.c:636:2: warning: 'cookie' may be used uninitialized in this function [-Wuninitialized] this patchseries introduces a new one: drivers/dma/fsldma.c: In function 'dma_do_tasklet': drivers/dma/fsldma.c:1134:16: warning: unused variable 'flags' [-Wunused-variable] I'll wait for a re-post, after these and Ira's comments are addressed, before trying to test again. Thanks, Kim [1] git://git.freescale.com/crypto/cryptodev.git -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html