> -----Original Message----- > From: Geanta Neag Horia Ioan-B05471 > Sent: Wednesday, July 11, 2012 3:09 PM > To: Liu Qiang-B32616 > Cc: linux-crypto@xxxxxxxxxxxxxxx; linuxppc-dev@xxxxxxxxxxxxxxxx; Li Yang- > R58472; Phillips Kim-R1AAHA; Herbert Xu; David S. Miller > Subject: RE: [PATCH 4/4] Talitos: fix the issue of dma memory leak > > On Tue, 10 Jul 2012 09:00:14 +0300, Qiang Liu <qiang.liu@xxxxxxxxxxxxx> > wrote: > > An error will be happened when test with mass data: > > "DMA-API: device driver tries to sync DMA memory it has not > > allocated"; > > "DMA-API: debugging out of memory - disabling" > > dma mapping memory of request->desc is not released by right device, > > it should be private->dev but not dev; > > > > Cc: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> > > Cc: David S. Miller <davem@xxxxxxxxxxxxx> > > Signed-off-by: Qiang Liu <qiang.liu@xxxxxxxxxxxxx> > > --- > > drivers/crypto/talitos.c | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) diff --git > > a/drivers/crypto/talitos.c b/drivers/crypto/talitos.c index > > 81f8497..a7da48c 100644 > > --- a/drivers/crypto/talitos.c > > +++ b/drivers/crypto/talitos.c > > @@ -264,7 +264,7 @@ static void flush_channel(struct device *dev, int > > ch, int error, int reset_ch) > > else > > status = error; > > - dma_unmap_single(dev, request->dma_desc, > > + dma_unmap_single(priv->dev, request->dma_desc, > > sizeof(struct talitos_desc), > > DMA_BIDIRECTIONAL); > > Are you sure this fix applies to the upstream version of talitos? > (i.e. have you encountered the error while running on cryptodev.git ?) > I found it on our own git, I'm going to test it. I will send the result later. Thanks. > Looks to me this is a fix for the not-upstreamed-yet NAPI patch (which > needs to be reworked according to Dave's feedback). > > When you respin the patch series, consider removing this one. Thanks for your mention, I will remove it if I cannot reproduce it. > Cheers, > Horia > -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
