On Sat, Jun 30, 2012 at 01:18:51AM -0700, David Miller wrote: > From: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> > Date: Wed, 27 Jun 2012 14:51:44 +0800 > > > While using the NAPI concept definitely makes sense, I'm still > > unsure about using napi_struct directly in crypto code. Dave, > > did you have a chance to look at their patch to use NAPI in their > > crypto driver? > > So I think using the existing napi context is overkill for a crypto > driver, there is so much stuff in that structure that will not be used > and just end up being wasted space. > > Better to create a crypto_napi struct that caters more closely to > just what crypto driver need. Yeah I agree completely. In fact, now that I have had a bit more time to think this through it seems that what they need isn't necessarily NAPI but better management of the tasklet to achieve the same level of turnaround performance as provided by NAPI + net_rx_action. I'll try to spend some time on this next week. Thanks, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
