Hi Phil, thanks for providing these patches; it's great to finally see DMA support for CESA in the kernel. Additionally, the implementation seems to be fine regarding cache incoherencies (at least my test in [*] works). I have two patches for your patchset... - Fix for mv_init_engine error handling - My system locked up hard when mv_dma and mv_cesa were built as modules. mv_cesa has code to enable the crypto clock in 3.5, but mv_dma already accesses the CESA engine before. Thus, we need to enable this clock here, too. [*] http://www.spinics.net/lists/arm-kernel/msg176913.html Simon Baatz (2): mv_dma: fix mv_init_engine() error case ARM: Orion: mv_dma: Add support for clk arch/arm/mach-kirkwood/common.c | 1 + drivers/crypto/mv_dma.c | 18 +++++++++++++++--- 2 files changed, 16 insertions(+), 3 deletions(-) -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html