On Thu, May 31, 2012 at 08:45:58AM +0200, Mathias Krause wrote: > > No, but the latter will likely be much slower as it would need to > memmove the data if it's not aligned, right? Most crypto users should already be providing aligned data. After all, padlock-aes requires 16-byte alignment and it works quite well. > That said, I did some micro benchmark on "pxor (%edx), %xmm0" vs. > "movups (%edx), %xmm1; pxor %xmm1, %xmm0" and observed the latter > might be even slightly faster! But changing the code to perform better > is out of scope for this patch as it should just fix the bug in the > code. We can increase performance in a follow up patch. OK we can do that. Thanks, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html