On Tue, May 8, 2012 at 9:37 PM, Arnd Bergmann <arnd@xxxxxxxx> wrote:
> On Tuesday 08 May 2012, Andreas Westin wrote:
>> This adds the required platform data and calls to enable
>> the CRYP/HASH driver.
>>
>> index 15a0f63..a69db46 100644
>> --- a/arch/arm/mach-ux500/id.c
>> +++ b/arch/arm/mach-ux500/id.c
>> @@ -17,7 +17,10 @@
>> #include <mach/hardware.h>
>> #include <mach/setup.h>
>>
>> +#include <linux/module.h>
>> +
>> struct dbx500_asic_id dbx500_id;
>> +EXPORT_SYMBOL(dbx500_id);
>>
>> static unsigned int ux500_read_asicid(phys_addr_t addr)
>> {
>
> This needs an explanation! Why do you export an internal data structure
> to non-GPL modules?
This does not look like it's needed at all, none of the other two patches use
it. Andreas can you just drop this hunk of the patch?
BTW if the asic variant is needed by some driver use cpu_is_*() from
<mach/id.h> or pass a flag in platform data or something.
> On a more general topic, I wonder if it's really necessary to add new
> devices to the legacy probing path in mach-ux500. Why not make new drivers
> for this platform dt-only, so we don't need to add code now that we will
> have to remove again in one or two kernel releases?
This is a simple platform_device which means that its IRQ/PIO mode is
already supported with standard bindings if you instantiate the device
from drivers/of/platform.c using the generic bindings for platform devices
and their resources.
The only thing that is passed in platform data, as you can see is the
DMA channels and configuration, which is debated elsewhere I
think. The day we know how to pass DMA channels to any platform/amba
device this device should be trivial to fully support with DT.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
