Re: [PATCH 1/1] Added CRYPTO_ALG_KERN_DRIVER_ONLY flag (3rd attempt)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Nikos Mavrogiannopoulos <nmav@xxxxxxxxxx> wrote:
> The added CRYPTO_ALG_KERN_DRIVER_ONLY indicates whether a cipher
> is only available via a kernel driver. If the cipher implementation
> might be available by using an instruction set or by porting the
> kernel code, then it must not be set.
> 
> In addition it provides crypto_tfm_alg_flags() to obtain
> this and other possible flags.
> 
> Signed-off-by: Nikos Mavrogiannopoulos <nmav@xxxxxxxxxx>

For future reference a cc to me is appreciated.

> +static inline u32 crypto_tfm_alg_flags(struct crypto_tfm *tfm)
> +{
> +       return tfm->__crt_alg->cra_flags;
> +}
> +

Who is going to use this? For one it's not type-safe as we try
to avoid directly using crypto_tfm in kernel code.

Otherwise your patch looks OK.

Cheers,
-- 
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux